Flexible comb_thresh_l
The comb_thresh_l is hard-coded in SNOWPACK, thereby limiting the effect of HEIGHT_NEW_ELEM, which can be specified in the ini file: const double SnowStation::comb_thresh_l = 0.015;
For example, in the ice-layer paper in The Cryosphere, I was using high resolution simulations, in which case I had to adjust both the ini file and the source code, in order to maintain high vertical resolution. Of course, I could also have set COMBINE_ELEMENTS to false in the ini-file, but that was increasing the computational load for the dual domain approach, without additional improvement in simulation accuracy. Optimal setting was achieved by modifying comb_thresh_l in the source code.
My suggestion would be that either:
- comb_thresh_l becomes a key in ini file
- or the source code specifies a fixed ratio between HEIGHT_NEW_ELEM and comb_thresh_l, such that the latter is scaled according to the prescribed HEIGHT_NEW_ELEM.
Any (other) ideas?