Obsolete code?
The function ElementData::soilFieldCapacity() in DataClasses.cc seems to contain some obsolete code piece:
if (!(rg > 0.)) { fc = MIN(SnLaws::field_capacity_soil, (1. - theta[SOIL]) * 0.1); } else {
- First of all, when can rg be negative? I'm not aware of any use of negative rg in the current SNOWPACK version. Seems to be an old remnant.
- Given that SnLaws::field_capacity_soil == 0.15, and (1. - theta[SOIL]) * 0.1) will never exceed 0.1, the MIN function will always pick the latter...