GitLab

Even though COUPLEDPHASECHANGES seems to work now and should provide more accurate energy balance results, it seems to increase the runtime of the res1exp example from 38s to 55s. Therefore making COUPLEDPHASECHANGES = FALSE the default.

This should be warning free!

Fixed a few warnings "implicitly-declared ... is deprecated" and fixed a resource issue (Readme.txt)

With SNOWPACK::INFLATE_ALLOW it is possible to turn on/off inflate/deflate both
in operational and research mode (note that by default, it is turned off in
research and on in operational). If SNOWPACK::INFLATE_INFO is set to true, then
a message is printed every time inflate/deflate changes the mass balance.

Otherwise, the OSWR fields in the exmaple smet files have been renamed as RSWR.

Bug fix for instabilities of the temperature solver with phase changes. The element temperature was erroneously recalculated after the surface node was adjusted to prevent output with a surface temperature above melting temperature when ice is present in the surface element.

Corrected stability following the original euqations of Stearns & Weidner (1993)

See merge request !1

Set MO_HOLTSLAG as default stability (for now it is dummy, since is is overwritten by cfg.get("ATMOSPHERIC_STABILITY", "Snowpack")

In some simulations, a very small negative theta[AIR] appeared (in the order of
1e-17). This would crash the simulation when computing the diffusion coefficient
for water vapor transport (because of the negative number). Since such an
element would be cleaned up later (this is just a zero that misbehaved), a true
zero is now used in the computation instead.

Making the call to the new sea ice initialization function optional (to set volume content, temperature and salinity, and pressure head consistently), using the key CHECK_INITIAL_CONDITIONS.

Introducing a sea ice initialization function to set volume content, temperature and salinity, and pressure head consistently.

Make sure that Richards equation can print the simulation date in messages, and improving messages and code logic for salinity transport inside Richards equation.

Renaming useNewPhaseChange to coupledphasechanges (indicating the coupling with the heat equation) and making it a config option.