WSL/SLF GitLab Repository

Commit bb55a368 authored by Mathias Bavay's avatar Mathias Bavay
Browse files

The splitting was computed using TOA_beam when it should have used TOA_h...

The splitting was computed using TOA_beam when it should have used TOA_h (after checking the Reindl, 1990 paper)
parent 6a52089f
......@@ -276,8 +276,9 @@ void SunObject::getSlopeRadiation(const double& slope_azi, const double& slope_e
* measured incoming global radiation to top of the atmosphere radiation toa_h,
* see
* D. G. Erbs, S.A. Klein, J.A. Duffie, <i>"Estimation of the diffuse radiation fraction for hourly, daily and monthly-average global radiation"</i>, Solar Energy, <b>28</b>, 4, 1982, Pages 293-302 and
* M. Iqbal, <i>"An introduction to solar radiation"</i>, 1983, Academic Press, ISBN: 0-12-373750-8
* @param iswr_modeled modelled radiation, it should be beam Top Of Atmosphere Radiation (W/m²)
* M. Iqbal, <i>"An introduction to solar radiation"</i>, 1983, Academic Press, ISBN: 0-12-373750-8 and
* D. T. Reindl, W. A. Beckman, J. A. Duffle, <i>"Diffuse fraction correlations</i>, Solar Energy, <b>45</b>, 1990, pp 1-7.
* @param iswr_modeled modelled radiation, it should be horizontal Top Of Atmosphere Radiation (W/m²)
* @param iswr_measured measured Incoming Short Wave Radiation on the ground (W/m²)
* @return splitting coefficient (between 0 and 1, 1 being 100% diffuse radiation)
*/
......@@ -318,7 +319,9 @@ double SunObject::getSplitting(const double& iswr_modeled, const double& iswr_me
double SunObject::getSplitting(const double& iswr_measured) const
{
return getSplitting(beam_toa, iswr_measured);
double toa_h, direct_h, diffuse;
getHorizontalRadiation(toa_h, direct_h, diffuse);
return getSplitting(toa_h, iswr_measured);
}
const std::string SunObject::toString() const
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment